TextToolbar - Switch Format from Custom Formatter

[WilliamABradley]

Fix for #1449.

-Added Two Way Binding to Format Property.

-Added new Reset Layout Command, Defaults the Toolbar to Default Configuration.

-You can now Clear the Custom Buttons ButtonMap.

[WilliamABradley]

@nmetulev @michael-hawker I now have two way binding, but it doesn't seem to update the ComboBox UI. Is there a Shell command or something to update the properties of a Binding from code behind?

Found a way to update ComboBox UI

[nmetulev]

@WilliamABradley, there are two things that need to be done to get the ComboBoxUI to work.

1. First, there is a bug in the sample app that needs to be fixed. It's a very small fix, so I think it can be included here. The EnumConverter convert method needs to make sure it is returning a string. Adding .ToString() on value should do it.

2. In your method for using Custom Formatter, make sure you are actually updating the baking property for the binding instead of directly changing the Format on the control. To do this, you need to get a reference to the ValueHolder for the property. Here is the code that should do it:

   private void UseCustomFormatter()
   {
       if (_toolbar == null)
       {
           return;
       }
   
       var sample = DataContext as Sample;
       var properties = sample.PropertyDescriptor.Expando as System.Collections.Generic.IDictionary<string, object>;
       if (properties.TryGetValue("Format", out var format))
       {
           var formatter = new SampleFormatter(_toolbar);
           (format as Models.ValueHolder).Value = UI.Controls.TextToolbarFormats.Format.Custom;
           _toolbar.Formatter = formatter;
       }
   }
   
   

Once you do this, the behavior you are after will work. However, because properties are remembered from sample to sample, there is an exception that is thrown when you you navigate to the sample again after setting the Format to Custom. Steps to reproduce (after doing the above changes):

1. Navigate to the TextToolbar sample
2. Hit the Use Custom Formatter command
3. Navigate back from the sample
4. Navigate to the sample again (notice Format will be remembered as Custom)
5. Hit Reset Layout. This will throw an exception (that is handled by the app)

Not sure if this is an issue with the sample or the control itself, but it should be looked at.

[nmetulev]

@WilliamABradley, up?

[nmetulev]

Up?

[WilliamABradley]

I'll see if I can do this later today

[WilliamABradley]

@nmetulev All done :)

[nmetulev]

Works as advertised :)

[IbraheemOsama]

You need to check for null here unless you're sure then (cast) don't (as).
Same thing for the if(properties.TryGetValue), properties could be null because of the as.

[WilliamABradley]

@IbraheemOsama Added some Null Safeties.

[IbraheemOsama]

@WilliamABradley perfect :)