New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(SystemInformation): add list of possible DeviceFamily #1824
Conversation
I would start the comments with "Common values include:" and end with "Prepare your code for other values." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would start the comments with "Common values include:" and end with "Prepare your code for other values."
It has to be clear that the list is not complete.
/// <term>"Windows.Xbox"</term> | ||
/// </item> | ||
/// <item> | ||
/// <term>"Windows.Holographic"</term> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add more after each point like common devices that use these types? i.e. HoloLens and Mixed Reality devices for holographic and Surface Hub for Team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We can add more information on the <description>
node. The best option would be to add it on each item value but we need to be sure what to add on it. Like for Windows.Desktop
, I suppose it englobes desktops, laptops and tablets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add it in a future PR if it is necessary.
This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1789 |
Issue: #1789
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Show basic Intellisense info on SystemInformation.DeviceFamily property.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the new behavior?
Add list of possible values of SystemInformation.DeviceFamily property in XML docs so devs can see them when using the property.
Does this PR introduce a breaking change?
Other information
@XamlBrewer Not sure what to do about the link to Microsoft docs.