Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac: Folders created by git are not expanded after git command completes #264

Closed
wilbaker opened this issue Sep 12, 2018 · 0 comments
Closed

Comments

@wilbaker
Copy link
Member

wilbaker commented Sep 12, 2018

This issue can be reproduced by running the CheckoutTests.DeleteFileThenCheckout functional test.

The test fails because when TestValidationAndCleanup runs the repo is in this state:

  • GitCommandsTests/DeleteFileTests/1/#test is in ModifiedPaths.Dat
  • GitCommandsTests/DeleteFileTests is not on disk

Then TestValidationAndCleanup checks out the control commit (which does have GitCommandsTests/DeleteFileTests, and it has several child folders).

When the checkout occurs git creates DeleteFileTests, DeleteFileTests/1, and DeleteFileTests/1/#test. When git creates the folders (unlike in VFSForGit on Windows) the folders are not marked as empty (or recorded as needing to be re-expanded).

As a result, when the command completes DeleteFileTests (and DeleteFileTests/1) are never expanded again and all of their children (other than #test) are missing.

@wilbaker wilbaker added this to TODO in Porting to Mac via automation Sep 12, 2018
@wilbaker wilbaker moved this from TODO to In Progress in Porting to Mac Oct 9, 2018
@wilbaker wilbaker self-assigned this Oct 9, 2018
Porting to Mac automation moved this from In Progress to Done Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant