Switching to HashSet for the list of files to be prefetched to improv… #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e performance, when the list is long
kewillford
approved these changes
Feb 22, 2019
…ToLower, as per code review suggestion
nickgra
approved these changes
Feb 23, 2019
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e performance, when the list is long.
Addreses #826
Before this change, if we were prefetching a list of ~4k files, the traversal of that list in
ShouldIncludeResultmethod took ~70ms. After the change, the lookup in the HashSet is almost instant (testing showed it to take 0ms)