Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server still doesn't dispose properly - 0.0.19092 #262

Closed
2 tasks
SahilTara opened this issue Apr 2, 2019 · 2 comments
Closed
2 tasks

Server still doesn't dispose properly - 0.0.19092 #262

SahilTara opened this issue Apr 2, 2019 · 2 comments
Labels
bug Something is broken Wizard Wizard issue
Projects
Triage
Milestone
0.1 - Feature Com...

Comments

@SahilTara
Copy link
Collaborator

Repro Steps:

  • Launch extension 0.0.19092
  • Launch wizard
  • Close vscode

Things to consider before it is marked as finished:

  • disposes on extension uninstall + reload.
  • disposes on vs code close.
@SahilTara SahilTara added bug Something is broken Extension Extension related work labels Apr 2, 2019
@SahilTara SahilTara self-assigned this Apr 2, 2019
@SahilTara SahilTara added this to Needs triage in Triage via automation Apr 2, 2019
@SahilTara SahilTara moved this from Needs triage to High priority in Triage Apr 2, 2019
@SahilTara SahilTara mentioned this issue Apr 2, 2019
Merged
@traore-i traore-i added Wizard Wizard issue and removed Extension Extension related work labels Apr 2, 2019
@SahilTara
Copy link
Collaborator Author

Windows:

  • disposes on extension uninstall + reload.
  • disposes on vs code close.

Verified on v0.0.19093-5

Linux and Mac still don't dispose properly!

@SahilTara SahilTara mentioned this issue Apr 3, 2019
Merged
@ngkelly3 ngkelly3 closed this as completed Apr 4, 2019
Triage automation moved this from High priority to Closed Apr 4, 2019
@SahilTara
Copy link
Collaborator Author

Verified on v0.0.19094-2 MacOS, Ubuntu, Windows

@SahilTara SahilTara added this to the 0.1 - Feature Complete milestone Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken Wizard Wizard issue
Projects
No open projects
Triage
  
Closed
Milestone
0.1 - Feature Complete
Development

No branches or pull requests
3 participants
@ngkelly3 @SahilTara @traore-i