Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include "Universal Windows" in VS Project Template name #478

Merged
merged 1 commit into from Jun 19, 2017

Conversation

ralarcon
Copy link
Contributor

The Project Template name is replaced at build time in order to change it for each environment (loca, dev-nightly, pre-release and pro).

Updated the name in the local template and changed the builds variables to include "Universal Windows" as part of the name.

@msftclas
Copy link

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@crutkas
Copy link
Member

crutkas commented Jun 19, 2017

how will this work in once we start supporting xamarin?

@crutkas crutkas merged commit 2e2328a into dev Jun 19, 2017
@mrlacey
Copy link
Collaborator

mrlacey commented Jun 19, 2017

It depends on how you want the Xamarin integration to work.

If we think about it on its own then it makes sense for an option to create Xamarin projects to be under the Cross-Platform group (see image below). In this case, it would make sense to have the bracketed suffixes to distinguish between multiple items in the single list of all templates.

image

If the intention is to add Xamarin[.Forms] as another option under frameworks in the current wizard, it might be weird that getting to this is via a template in the "Windows Universal" folder. It would be fine for people wanting to create a UWP app with XF ready to move to other platforms but wouldn't be great for people specifically wanting to target multiple platforms from the start.

I expect that Xamarin would prefer to have a separate template entry. I think it's the better option too, but it does raise some questions:

  • Should you also be able to select Xamarin as a Framework for the UWP version?
  • If targeting Xamarin.Forms as a framework, what about using other frameworks (MVVM Light, MVX, etc.) with it? as this is popular.
  • If there is a cross-platform entry should that only be limited to creating Xamarin projects?
  • Would both templates be installed together? Even if the machine only has one of the UWP or Xamarin tooling installed?
  • and more questions for another time.... ;)

@crutkas
Copy link
Member

crutkas commented Jun 19, 2017

Most of these should be in the XF issue.

  • I think you'd be able to see Xamarin in UWP area
  • the framework question comes into massive play here as a best POR. I think the wizard will need to be tweaked no matter what.
  • dealing with tool detection is a great item to bring up. I didn't think about that

@crutkas
Copy link
Member

crutkas commented Jun 19, 2017

xref #321 for XF issue

@ralarcon
Copy link
Contributor Author

I fill more natural to have an entry under "cross platform" for xamarin; this would just run the wizard pre-filtered because I guess xamarin would have different frameworks and project types too...

@ralarcon ralarcon deleted the Issue324-UniversalWindowsSuffix branch June 22, 2017 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants