Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More space in login message for line wrap #4

Closed
wants to merge 1 commit into from

Conversation

f-bader
Copy link

@f-bader f-bader commented Nov 22, 2017

The item #loginMessage only allows single line messages.
In German the is a line wrap and the text would float above the user text input.
Doubled the height so line wrap is possible

The item #loginMessage only allows single line messages.
In German the is a line wrap and the text would float above the user text input.
Doubled the height so line wrap is possible
@bongiovimatthew-microsoft
Copy link
Contributor

@f-bader, thank you for catching this. You're right that the line overflows on top of the text box when it's too long. I think instead of adjusting the height to be twice as tall, we should adjust the height to 'auto', which will maintain the narrow distance when the text is one line, but will push the text box below the message when the words wrap to a second line.

I have included the height to 'auto' fix in a separate pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants