Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nice to have deadlettering #17

Closed
ryancrawcour opened this issue Mar 19, 2019 · 2 comments
Closed

Nice to have deadlettering #17

ryancrawcour opened this issue Mar 19, 2019 · 2 comments
Labels
enhancement New feature or request
Milestone
P2

Comments

@ryancrawcour
Copy link
Contributor

Include an optional setting where you can specify a deadletter Kafka stream in your config somewhere and it will deadletter to that for you after retries have been exceeded.
@ryancrawcour ryancrawcour added this to the P2 milestone Mar 19, 2019
@ryancrawcour ryancrawcour mentioned this issue Mar 19, 2019
Closed
@fbeltrao fbeltrao mentioned this issue Mar 24, 2019
Merged
@fbeltrao
Copy link
Contributor

Another topic for discussion is whether or not we should retry calling the function if it failed. A retry logic and then finally moving to a deadlettering.
@ryancrawcour

@TsuyoshiUshio TsuyoshiUshio added the enhancement New feature or request label Jun 27, 2020
@shrohilla
Copy link
Contributor

After several discussions we have added the support for retry to the customers and let customers handle it's own Dead letter. So closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
P2
Development

No branches or pull requests
4 participants
@fbeltrao @TsuyoshiUshio @ryancrawcour @shrohilla