Add serializer to serialize webapp configurations to pom #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #544 +/- ##
===========================================
- Coverage 41.33% 39.16% -2.17%
===========================================
Files 67 71 +4
Lines 2383 2515 +132
Branches 309 327 +18
===========================================
Hits 985 985
- Misses 1327 1459 +132
Partials 71 71
Continue to review full report at Codecov.
|
jdneo
requested changes
Jan 3, 2019
...-webapp-maven-plugin/src/main/java/com/microsoft/azure/maven/webapp/WebAppConfiguration.java
Outdated
Show resolved
Hide resolved
...aven-plugin/src/main/java/com/microsoft/azure/maven/webapp/configuration/RuntimeSetting.java
Outdated
Show resolved
Hide resolved
...aven-plugin/src/main/java/com/microsoft/azure/maven/webapp/configuration/RuntimeSetting.java
Outdated
Show resolved
Hide resolved
...gin/src/main/java/com/microsoft/azure/maven/webapp/serializer/V1ConfigurationSerializer.java
Outdated
Show resolved
Hide resolved
...gin/src/main/java/com/microsoft/azure/maven/webapp/serializer/V2ConfigurationSerializer.java
Outdated
Show resolved
Hide resolved
jdneo
reviewed
Jan 3, 2019
...gin/src/main/java/com/microsoft/azure/maven/webapp/serializer/V1ConfigurationSerializer.java
Outdated
Show resolved
Hide resolved
andxu
reviewed
Jan 4, 2019
| } else { | ||
| throw new MojoExecutionException( | ||
| String.format("Unknown value of <webContainer>. Supported values are %s.", | ||
| StringUtils.join(runtimeStackMap.keySet().toArray(), ","))); |
andxu
reviewed
Jan 4, 2019
| final DOMElement resourceRootNode = new DOMElement("resources"); | ||
| for (final Resource resource : resources) { | ||
| final DOMElement resourceNode = new DOMElement("resource"); | ||
| if (StringUtils.isNotEmpty(resource.getFiltering())) { |
There was a problem hiding this comment.
a private util method to check and create
andxu
reviewed
Jan 4, 2019
| resourceNode.add(XMLUtils.createSimpleElement("directory", resource.getDirectory())); | ||
| } | ||
|
|
||
| if (resource.getIncludes() != null && resource.getIncludes().size() > 0) { |
There was a problem hiding this comment.
a private util method to check and create
andxu
reviewed
Jan 4, 2019
| PricingTierEnum.getPricingTierStringByPricingTierObject(webAppConfiguration.getPricingTier()), | ||
| configurationElement); | ||
|
|
||
| coinfigRuntime(webAppConfiguration, configurationElement); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add serializer to serialize webapp configurations to pom, for webapp:config