don't include old packages in the .tgz #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtbassmatt
approved these changes
Dec 6, 2018
|
Hmm, for whatever reason, those bogus .tgzs don't seem to exist in CI. |
It starts from a clean slate on the build machine. I'm trying figure out how to make deleting a file that doesn't exist not fail... |
|
|
|
Also, if CI is able to build it cleanly, that might be good enough. Since we should only be shipping CI system outputs, not dev machine builds, right? 😉 |
Nope, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tarball for version 0.4.1 was huge because it included several old builds. More aggressive cleaning may be needed in the future, but this should work for now.