Microsoft/users/aujensen/vs2019 vs task #9273
Conversation
| } | ||
| } catch { | ||
| Write-Verbose ($_ | Out-String) | ||
| $script:visualStudioCache['6.0'] = $null |
|
@austin-jensen where is your task.json change that consume this common library change? |
| @@ -227,6 +237,63 @@ function Get-VisualStudio_15_0 { | |||
| } | |||
| } | |||
|
|
|||
| function Get-VisualStudio_16_0 { | |||
There was a problem hiding this comment.
consider parameterize existing function
| @@ -49,6 +49,7 @@ try { | |||
| $msBuildVersion = $null; | |||
| switch ("$vsVersion") { | |||
| '' { $msBuildVersion = '14.0' ; break } # VS wasn't found. Attempt to find MSBuild 14.0 or lower. | |||
| '16.0' { $msBuildVersion = '16.0' ; break } | |||
There was a problem hiding this comment.
make sure to bump the version for any tasks that consume the msbuildhelpers module
|
The VSTestV2 task also needs to be updated to detect/support VS2019. Will that be added to this PR, or in a separate one? |
|
@jimmylewis That will be done separately, as a lot of people are currently complaining about not being able to build with visual studio 2019. So we are trying to get the msbuild and vsbuild tasks out quickly |
| [System.Reflection.Assembly]$msUtilities = $null | ||
| if (($Version -eq "15.0" -or !$Version) -and # !$Version indicates "latest" | ||
| if (($Version -eq "16.0" -or !$Version) -and # !$Version indicates "latest" | ||
| ($visualStudio16 = Get-VisualStudio_16_0) -and |
There was a problem hiding this comment.
Get-VisualStudio_16_0?
| $msUtilities = [System.Reflection.Assembly]::LoadFrom($msbuildUtilitiesPath) | ||
| } | ||
| } | ||
| elseif (($Version -eq "15.0" -or !$Version) -and # !$Version indicates "latest" | ||
| ($visualStudio15 = Get-VisualStudio_15_0) -and |
There was a problem hiding this comment.
Get-VisualStudio_15_0?
| @@ -193,16 +206,16 @@ function Get-VisualStudio_15_0 { | |||
| $null = $output.AppendLine($_) | |||
| } | |||
| } | |||
| $script:visualStudioCache['15.0'] = (ConvertFrom-Json -InputObject $output.ToString()) | | |||
| $script:visualStudioCache["$MajorVersion.0"] = (ConvertFrom-Json -InputObject $output.ToString()) | | |||
There was a problem hiding this comment.
not sure whether you can just use visualStudioCache[$MajorVersion] as key, do we have to do "$MajorVersion.0"?
Tasks/MSBuildV1/task.json
Outdated
| @@ -11,7 +11,7 @@ | |||
| "author": "Microsoft Corporation", | |||
| "version": { | |||
| "Major": 1, | |||
| "Minor": 120, | |||
| "Minor": 121, | |||
There was a problem hiding this comment.
i think it should be the milestone number 1.146.0
| @@ -330,6 +330,26 @@ function Locate-SqlPackageInVS_15_0() | |||
| return $null, 0 | |||
| } | |||
|
|
|||
| function Locate-SqlPackageInVS_16_0() | |||
| { | |||
| $vs16 = Get-VisualStudio_16_0 | |||
There was a problem hiding this comment.
i would not change this task in this PR, send email to the owner of this task, let them deal with it.
| @@ -15,7 +15,7 @@ | |||
| "author": "Microsoft Corporation", | |||
| "version": { | |||
| "Major": 1, | |||
| "Minor": 3, | |||
| "Minor": 2, | |||
Tasks/VSBuildV1/task.json
Outdated
| @@ -11,8 +11,8 @@ | |||
| "author": "Microsoft Corporation", | |||
| "version": { | |||
| "Major": 1, | |||
| "Minor": 126, | |||
| "Patch": 2 | |||
| "Minor": 127, | |||
Tasks/XamarinAndroidV1/task.json
Outdated
| @@ -11,8 +11,8 @@ | |||
| "author": "Microsoft Corporation", | |||
| "version": { | |||
| "Major": 1, | |||
| "Minor": 143, | |||
| "Patch": 1 | |||
| "Minor": 144, | |||
There was a problem hiding this comment.
let task author change this.
Tasks/XamariniOSV2/task.json
Outdated
| @@ -11,8 +11,8 @@ | |||
| "author": "Microsoft Corporation", | |||
| "version": { | |||
| "Major": 2, | |||
| "Minor": 142, | |||
| "Patch": 2 | |||
| "Minor": 143, | |||
There was a problem hiding this comment.
let task author change this.
|
i would only include change to VSBuild/Msbuild task, and let other task author know they need to react. |
…get visual studio calls
austin-jensen
force-pushed
the
Microsoft/users/aujensen/VS2019VSTask
branch
from
bb71732
to
4cbbcc5
Compare
VS2019 support for VSBuild and MSBuild tasks
VS2019 support for VSBuild and MSBuild tasks
VS2019 support for VSBuild and MSBuild tasks
|
Any news here? I'm trying to build with 2019 build tools on a TFS 2015 on site installer... |
Added support for msbuild task and vsbuild task for visual studio 2019