Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Git repositories cloned from VSTS/visualstudio.com using the "new" url aren't detected by the vsts extension #333

Closed
bearcage opened this issue Nov 4, 2017 · 4 comments

Comments

@bearcage
Copy link
Contributor

bearcage commented Nov 4, 2017

Like the title says, if you clone a git repo from VSTS with the old ssh://acctname@acctname.visualstudio.com:22/DefaultCollection/_git/reponame URL, the vscode vsts extension will correctly detect it as a vsts repo. If, on the other hand, you update the remote to the new ssh://acctname@vs-ssh.visualstudio.com:22/DefaultCollection/_ssh/reponame format, the extension won't recognize it as a vsts workspace.

I checked for updates to the extension -- there don't appear to be any. For the time being I've just switched back to the old URL scheme, but as the giant deprecation banner warns when pulling from it, it's going away on the 17th.

It looks like the parsing code begins here and eventually winds up here. Since the VSTS clone URLs now use _ssh for that segment of the path, this won't cut it anymore.

@bearcage
Copy link
Contributor Author

bearcage commented Nov 4, 2017

I skimmed the open issues and PRs, doesn't look like this has been addressed yet, so I'll cut a PR quickly to remove the nesting (since clearly a git repo cloned from visualstudio.com is a VSTS repo)

@bearcage
Copy link
Contributor Author

bearcage commented Nov 8, 2017

Closed by merging #334.

@bearcage bearcage closed this as completed Nov 8, 2017
@hammady
Copy link

hammady commented Nov 1, 2018

Unfortunately, the ssh URLs have changed again to something like:
acctname@vs-ssh.visualstudio.com:v3/acctname/DefaultCollection/reponame which breaks the detection (again).

@hammady
Copy link

hammady commented Nov 1, 2018

This URL should work: git@vs-ssh.visualstudio.com:v3/acctname/DefaultCollection/reponame

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants