Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Added Sync command and tests #102

Merged
merged 2 commits into from
Feb 14, 2017
Merged

Added Sync command and tests #102

merged 2 commits into from
Feb 14, 2017

Conversation

jpricket
Copy link
Member

User Story #884949

User Story #884949
@msftclas
Copy link

Hi @jpricketMSFT, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Jason Prickett). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Copy link
Contributor

@jeffyoung jeffyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One possible change if you want to make it. LGTM.

hasErrors: false,
itemResults: []
};
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're returning in the IF, don't need the actual "else". Your call.

@jpricket
Copy link
Member Author

Sorry, I didn't realize you had already reviewed that first commit :)
I added one more that you may want to check out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants