This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Various linting updates #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 14, 2017 16:53
Enforce some new rules, be explicit about allowing JS to be compiled (the credential store is brought in as .js files)
jpricket
reviewed
Mar 15, 2017
| @@ -52,12 +52,12 @@ export class FileTokenStorage { | |||
| return deferred.promise; | |||
| } | |||
|
|
|||
| public RemoveEntries(entriesToRemove: Array<any>, entriesToKeep: Array<any>) : Q.Promise<void> { | |||
| public RemoveEntries(entriesToKeep: Array<any> /*, entriesToRemove?: Array<any>*/) : Q.Promise<void> { | |||
There was a problem hiding this comment.
did you want to leave the commented out parameter here?
There was a problem hiding this comment.
Yes, in case I ever actually want RemoveEntries to, well, remove the entries that are passed. :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Easier to review by looking at the commits.)
Removing unused variables, adding types as needed, disallow using 'var' keyword, more.