Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Multi-Select and Undo All #165

Merged
merged 2 commits into from
Apr 6, 2017
Merged

Multi-Select and Undo All #165

merged 2 commits into from
Apr 6, 2017

Conversation

jeffyoung
Copy link
Contributor

Add support for multi-select to several commands (Undo, Include, Exclude)
Add Undo All command

this.displayErrors(
async () => {
if (resource) {
if (resources) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slight optimization - check for resources.length > 0 to avoid the await below in that case

this.displayErrors(
async () => {
if (resource) {
let path: string = resource.resourceUri.fsPath;
if (resources) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Member

@jpricket jpricket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffyoung jeffyoung merged commit 93e681f into master Apr 6, 2017
@jeffyoung jeffyoung deleted the jeyou/multi-select branch April 6, 2017 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants