-
Notifications
You must be signed in to change notification settings - Fork 447
Conversation
Hi @mmanela, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
@@ -5,7 +5,7 @@ | |||
"use strict"; | |||
|
|||
import { FileSystemWatcher, StatusBarAlignment, StatusBarItem, window, workspace } from "vscode"; | |||
import { AccountSettings, Settings } from "./helpers/settings"; | |||
import { PinnedQuerySettings, AccountSettings, Settings } from "./helpers/settings"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preference is to alphabetize the imports
Hi Matt. Thanks for the contribution (very cool)! I wonder though if you gave any thought to having the "pinned query" be a name of a particular query instead of the WIQL? We'd have to look it up but it'd give the user more control over editing (using web access) and wouldn't require the user to craft WIQL? What do you think? |
I agree that would be nice. I plan to eventually give that option but wanted to do this first and in the future provide both options. The complication with the query path is just that we would need to always query for that first before running the query. Not a big deal just 2 calls instead of one. I plan to do this eventually: "team.pinnedQueries": [ |
Update the PR to respond to your other feedback |
@jeffyoung On second thought, I will add the queryPath support now ;) |
Query Path support added |
``` | ||
|
||
|
||
You can also create a *global* pinned query which will be the default if you have not configured one for your account: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since global also works for a query path, you may just update this text to explain that you can replace your-account-name with "global" and they'll both work. That means you can remove the sample below. Since "global" was introduced earlier with regards to PAT, they should already know what to change.
Thanks for adding the query path support so quickly! |
Update per your comments |
Merging. Thanks Matt! |
In the status bar we already have items for build and pull request. This pull request adds work item query there as well. I introduced the concept of a pinned query. This is a user configurable query that they will want real time feedback on.
By pinning the query you will get automatic updating of the number of items returned by it:
By clicking on the query you get those results. This is very useful since you can configure to quickly catch new items assigned to you or other items you want to track.
By default I use the same "my work items" query already in the code base but I let the user customize it in the user settings file with the following block: