This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Ensure Keep-Alive is true for HTTPS connections #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpricket
approved these changes
Jun 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help to resolve #59
I'm adding a private patch for NTLM.js in the vso-node-api module to properly set keep-alive for HTTPS connections. Here's the change to the file: Added keep-alive: true for HTTPS connections.
I'm doing a private patch because the vso-node-api has revved major versions (it underwent a major refactoring), is still in preview and NTLM support hasn't been added. Updating vso-node-api can be done in a follow up user story.
In these changes, I've checked in a private version of ntlm.js and use the gulpfile to move it into the vso-node-api node_module before we do the packaging of the extension (it overwrites the existing file). Doing this allows the packaged extension to contain the patched version.