This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Several miscellaneous fixes #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, the
setIntervalcalls should besetTimeoutas they should only be done once (since a message is being displayed on the status bar and it only needs to be cleared a single time).Second, removing the
awaiton the calls to showQuickPick actually allows the VS Code UI to show the status indicator on the Quick Pick. Only the Pull Request quick picks were showing them; WIT-related reuqests were not. I tracked it down to having added these awaits a while back.