This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add support for azure.com and other SSH URL formats #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnib
reviewed
Sep 13, 2018
| // | ||
| //NOTE: the detection of a TFS TFVC repository is basically a "catch all". Any url could match | ||
| //it and we'd think it's a TFVC repo. For that to be true, this class now assumes that it is | ||
| //always detecting either a Team Services or TFS repository. It no longer tries to determine | ||
| //that a url is NOT either a TFS or Team Services repository. So it is up to the caller to only | ||
| //instantiate this class if we know we should have either a TFS or Team Services repository. | ||
| export class RepoUtils { | ||
| private static sshV3 = new RegExp("git@(?:vs-)?ssh\.(.+):v3\/(.+)\/(.+)\/(.+)"); |
There was a problem hiding this comment.
VSTS now introduced a new version where the git@ is now replaced with the <VS account name>@.
Which means, the experience for SSH-cloned repos is broken again.
One thing to note, the old URIs, starting with git@ still work -- however, since the VSTS experience exposes the new format, then that's what people are going to use.
There was a problem hiding this comment.
Thank You @johnib ! If you're interested in fixing this please submit a PR and we'll happily review.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.