This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Improve checking of Team Foundation Server server name formats #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the extension checks for more valid server name formats for Team Foundation Servers
jeffyoung
force-pushed
the
jeyou/issue41
branch
from
ef9a9fa
to
4424b9a
Compare
|
Looks good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #41
Refactored GitContext so I could get better (some) coverage on the Team Foundation Server url validation. The existing code wasn't checking for the proper server name formats for Team Foundation Server deployments.
Added unit tests to verify the code changes. Also ran manual testing against Team Services, Team Foundation Server and non-Team Services repos.