This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Adding additional unit tests and new integration tests #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks, Jeff! |
|
Thank you for your help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the number of unit tests and gets more coverage on the GitContext object (which is responsible for determining whether a remote repository URL is Team Services, Team Foundation Server, or other).
The PR also introduces new integration tests that test the services used by the extension against actual data. The CI build definition contains build variables that instruct the tests where to connect and what values the tests should compare against. These tests will run on both a CI and scheduled basis.
I also added the ability to generate JUnit test results files that can be uploaded to the server (and shown in the build summary). I also added code coverage to the build definition so those results (and reports) will also display in the build summary.
I updated the CI build definition before this PR and ran it against my feature branch to ensure the new tests would run and all reporting would work as expected. The unit tests all run as expected on the cmd line via gulp as well as from within VS Code. If the env vars are set in the dev environment properly, the integration tests will run as well (and also from within VS Code).