TFVC command framework in place #66
Conversation
User Story #884931
|
Hi @jpricketMSFT, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| if (this.ensureInitialized()) { | ||
| try { | ||
| let tfvc: Tfvc = new Tfvc(); | ||
| let repo: Repository = tfvc.open("D:\\tmp\\tfsTest03_44"); |
There was a problem hiding this comment.
It'd be great to remove the hard-coded paths.
| * Create an instance of this class to build up the arguments that should be passed to the command line. | ||
| */ | ||
| export class ArgumentBuilder { | ||
| private arguments: string[] = []; |
There was a problem hiding this comment.
I typically prefix private member variables with underscores. Your call.
| this._localPath = localPath; | ||
| } | ||
|
|
||
| getArguments(): string[] { |
There was a problem hiding this comment.
I start public methods with a capital letter (private methods start with lowercase). I'm also typically explicit regarding private v public.
| return workspace; | ||
| } | ||
|
|
||
| private getValue(line: string): string { |
There was a problem hiding this comment.
A comment would be great as to what the incoming line looks like (presumably there's a ':' somewhere :-).
| this.tfvcPath = localPath; | ||
| } else { | ||
| // TODO get it from settings | ||
| this.tfvcPath = "D:\\tmp\\bin\\TEE-CLC-14.0.4\\tf.cmd"; |
removed hard coded paths, corrected cases on method names, explicitely declared methods as private/public.
User Story #884931