This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add add'l error handling and logging #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpricket
reviewed
Jan 31, 2017
| let valid: boolean = await this.validateTfvcCollectionUrl(serverUrl, this._handler); | ||
| if (!valid) { | ||
| Logger.LogDebug(`Unable to validate the Team Services TFVC repository. Collection: ${collectionName}, Url: ${serverUrl}`); | ||
| return undefined; //TODO: Handle this case (in the caller) | ||
| let error: string = `Unable to validate the Team Services TFVC repository. Collection name: '${collectionName}', Url: '${serverUrl}'`; |
There was a problem hiding this comment.
shouldn't this be localized since you are not just logging it?
jpricket
reviewed
Jan 31, 2017
| collectionName = "DefaultCollection"; | ||
| if (!this.validateTfvcCollectionUrl(url.resolve(serverUrl, collectionName), this._handler)) { | ||
| Logger.LogDebug(`Unable to validate the TFS TFVC repository with DefaultCollection`); | ||
| return undefined; //TODO: Handle this case (in the caller) | ||
| let error: string = `Unable to validate the TFS TFVC repository with DefaultCollection`; |
|
I'll add TODOs for localizing these. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.