Refactored extension classes #79
Conversation
This allows the context objects to be shared and the tfvc repo objects to be cached. User Story #884966
|
Hi @jpricketMSFT, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
src/tfvc/tfvc-extension.ts
Outdated
| import { Tfvc } from "./tfvc"; | ||
| import { Repository } from "./repository"; | ||
| import { UIHelper } from "./uihelper"; | ||
| import { IPendingChange } from "./interfaces"; | ||
|
|
||
| export class TfvcExtension { | ||
| private _tfvc: Tfvc = undefined; | ||
| private _repo: Repository = undefined; | ||
| private _manager: ExtensionManager; |
There was a problem hiding this comment.
I'm OK with not setting variables directly to undefined like you did here with ExtensionManager. But it'd be great to be consistent (and remove them from 15 and 16). I hope the rest of the code reflects it, but I only like to use "undefined" when I need to.
| } | ||
| } | ||
|
|
||
| dispose() { |
There was a problem hiding this comment.
See if we can remove this, if possible.
There was a problem hiding this comment.
Belay that request. Just put a comment in here that there's nothing to dispose so we don't get a linting violation.
src/tfvc/tfvc.ts
Outdated
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| import * as cp from "child_process"; | |||
| import { EventEmitter, Event } from "vscode"; | |||
| import { TeamServerContext} from "../contexts/servercontext"; | |||
User Story #884966
This allows the context objects to be shared and the tfvc repo objects to be cached.
User Story #884966