This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Show history for TFVC repositories #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpricket
reviewed
Feb 6, 2017
package.json
Outdated
| "tfvc.location": { | ||
| "type": "string", | ||
| "default": "", | ||
| "description": "Specify the full path to the TF executable to use for TFVC functionality." |
There was a problem hiding this comment.
should we change "TF executable" to "TF executable or script"? Doesn't matter much, but since we do support tf.cmd, it might be more "correct" to include script.
jpricket
reviewed
Feb 6, 2017
src/team-extension.ts
Outdated
| this._gitClient.OpenFileHistory(this._manager.RepoContext); | ||
| } else if (this._manager.RepoContext.Type === RepositoryType.TFVC) { | ||
| let editor = window.activeTextEditor; |
There was a problem hiding this comment.
consider whether this should simply be "this._manager.Tfvc.TfvcViewHistory()" and all the logic (under the TFVC else branch) be inside there. This would just keep this file a bit smaller.
jpricket
reviewed
Feb 6, 2017
src/tfvc/tfvc-extension.ts
Outdated
| if (!itemPath) { | ||
| this._manager.Telemetry.SendEvent(TfvcTelemetryEvents.OpenRepositoryHistory); | ||
| //Just display the history url of the entire repo | ||
| Utils.OpenUrl(this._manager.RepoContext.RemoteUrl + "_versionControl?_a=history"); |
There was a problem hiding this comment.
Does this assume that the RemoteUrl ends in "/"? Do we have a helper that join url paths like path.combine? That would be safer.
jpricket
reviewed
Feb 6, 2017
src/tfvc/tfvc-extension.ts
Outdated
| this._manager.Telemetry.SendEvent(TfvcTelemetryEvents.OpenFileHistory); | ||
| let serverPath: string = itemInfos[0].serverItem; | ||
| let file: string = encodeURIComponent(serverPath); | ||
| Utils.OpenUrl(this._manager.RepoContext.RemoteUrl + "_versionControl?path=" + file + "&_a=history"); |
jpricket
approved these changes
Feb 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.