This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Adding TFVC Undo command #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpricket
reviewed
Feb 9, 2017
src/tfvc/commands/commandhelper.ts
Outdated
| @@ -89,6 +89,9 @@ export class CommandHelper { | |||
| } | |||
| lines = lines.splice(index); | |||
| } | |||
| if (filterEmptyLines) { | |||
| lines = lines.filter(e => e !== ""); | |||
There was a problem hiding this comment.
you may want to trim() here to remove "blank" lines as well. Not sure if you want to or not.
jpricket
reviewed
Feb 9, 2017
src/tfvc/commands/undo.ts
Outdated
|
|
||
| public constructor(serverContext: TeamServerContext, itemPaths: string[]) { | ||
| if (!itemPaths || itemPaths.length === 0) { | ||
| throw TfvcError.CreateArgumentMissingError("itemPaths"); |
There was a problem hiding this comment.
Use CommandHelper.RequireStringArrayArgument here.
jpricket
reviewed
Feb 9, 2017
src/tfvc/commands/undo.ts
Outdated
| */ | ||
| public async ParseOutput(executionResult: IExecutionResult): Promise<string[]> { | ||
| //TODO: (Undo All) What if we've been passed 5 files and the 3rd has no pending changes? | ||
| if (CommandHelper.HasError(executionResult, "No pending changes were found for ")) { |
There was a problem hiding this comment.
Your TODO is valid. You may have errors and "Undoing edit" lines interlaced. You need to skip those errors and just continue.
jpricket
suggested changes
Feb 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.