Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages still doesn't collapse to bottom of page #3177

Closed
kevcunnane opened this issue Nov 9, 2018 · 3 comments
Closed

Messages still doesn't collapse to bottom of page #3177

kevcunnane opened this issue Nov 9, 2018 · 3 comments

Comments

@kevcunnane
Copy link
Contributor

Issue Type: Bug

Run a query such as create database. Collapse messages
Expected:

  • Messages goes to bottom of the editor since there's no content
    Actual:
  • Messages stays 1/3 up the screen. Smallest it'll go is 25%
  • It's confusing as below it is empty so it looks like a bug
    image

Azure Data Studio version: Azure Data Studio 1.2.4 (1ebfd02, 2018-11-02T21:36:55.143Z)
OS version: Darwin x64 18.2.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (1.81GB free)
Process Argv /Applications/Azure Data Studio.app/Contents/MacOS/Electron
Screen Reader no
VM 0%
Extensions (2)
Extension Author (truncated) Version
vscode-sanddance dan 0.0.1
sql-vnext Mic 0.8.0
@anthonydresser
Copy link
Contributor

I fixes one issue which was allowing messages to collapse down with respect to results. But there is a different request here which has never been a feature which is allowing the entire results grid to collapse down; which is a feature request that I can handle when I merge in my query editor refactor.

@kburtram
Copy link
Member

Here is a more recently reply on this issue that I'll capture here since this is the active tracking bug.

snipped from #5498
if the query returns enough results to fill the available screen space then the resultgrid should be resizable to fill that space. If the query doesn't return enough results to fill the screen then the messages pane will occupy the available space. There is more discussion of this behavior in #3177. Please let me know if that doesn't address your question.

I agree that the current behavior is confusing. We had a fix that collapsed the Message to the bottom even when the resultset didn't fill the available area, but that change had several side-effects and needed to be reverted. We're planning to move the Messages into its own tab soon, so we decided to wait for that change rather than try to correct the previous attempt at fixing this.

@kburtram
Copy link
Member

kburtram commented Jun 6, 2019

This is fixed in the June release.

@kburtram kburtram closed this as completed Jun 6, 2019
@adsbot adsbot bot locked and limited conversation to collaborators Jul 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants