Skip to content

Commit

Permalink
typing tests are sensitive to speed of machine, need to be longer del…
Browse files Browse the repository at this point in the history
…ays to make it consistent on build servers
  • Loading branch information
Tom Laird-McConnell committed Feb 8, 2020
1 parent d41968f commit bac6832
Showing 1 changed file with 20 additions and 20 deletions.
40 changes: 20 additions & 20 deletions tests/Microsoft.Bot.Builder.Tests/ShowTyping_MiddlewareTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,18 @@ public class ShowTyping_MiddlewareTests
public async Task ShowTyping_TestMiddleware_1_Second_Interval()
{
TestAdapter adapter = new TestAdapter(TestAdapter.CreateConversation(TestContext.TestName))
.Use(new ShowTypingMiddleware(100, 100));
.Use(new ShowTypingMiddleware(100, 1000));

await new TestFlow(adapter, async (context, cancellationToken) =>
{
await Task.Delay(TimeSpan.FromMilliseconds(400));
{
await Task.Delay(TimeSpan.FromMilliseconds(2500));
// note the ShowTypingMiddleware should not cause the Responded flag to be set
Assert.IsFalse(context.Responded);
// note the ShowTypingMiddleware should not cause the Responded flag to be set
Assert.IsFalse(context.Responded);
await context.SendActivityAsync("Message sent after delay");
await Task.CompletedTask;
})
await context.SendActivityAsync("Message sent after delay");
await Task.CompletedTask;
})
.Send("foo")
.AssertReply(ValidateTypingActivity, "check typing activity")
.AssertReply(ValidateTypingActivity, "check typing activity")
Expand All @@ -44,14 +44,14 @@ public async Task ShowTyping_TestMiddleware_1_Second_Interval()
public async Task ShowTyping_TestMiddleware_Context_Completes_Before_Typing_Interval()
{
TestAdapter adapter = new TestAdapter(TestAdapter.CreateConversation(TestContext.TestName))
.Use(new ShowTypingMiddleware(100, 100));
.Use(new ShowTypingMiddleware(100, 5000));

await new TestFlow(adapter, async (context, cancellationToken) =>
{
await Task.Delay(TimeSpan.FromMilliseconds(150));
await context.SendActivityAsync("Message sent after delay");
await Task.CompletedTask;
})
{
await Task.Delay(TimeSpan.FromMilliseconds(2000));
await context.SendActivityAsync("Message sent after delay");
await Task.CompletedTask;
})
.Send("foo")
.AssertReply(ValidateTypingActivity, "check typing activity")
.AssertReply("Message sent after delay")
Expand All @@ -63,13 +63,13 @@ public async Task ShowTyping_TestMiddleware_Context_Completes_Before_Typing_Inte
public async Task ShowTyping_TestMiddleware_ImmediateResponse_5SecondInterval()
{
TestAdapter adapter = new TestAdapter(TestAdapter.CreateConversation(TestContext.TestName))
.Use(new ShowTypingMiddleware(2000, 500));
.Use(new ShowTypingMiddleware(2000, 5000));

await new TestFlow(adapter, async (context, cancellationToken) =>
{
await context.SendActivityAsync("Message sent after delay");
await Task.CompletedTask;
})
{
await context.SendActivityAsync("Message sent after delay");
await Task.CompletedTask;
})
.Send("foo")
.AssertReply("Message sent after delay")
.StartTestAsync();
Expand All @@ -82,7 +82,7 @@ public void ShowTyping_TestMiddleware_NegativeDelay()
try
{
TestAdapter adapter = new TestAdapter(TestAdapter.CreateConversation(TestContext.TestName))
.Use(new ShowTypingMiddleware(-100, 100));
.Use(new ShowTypingMiddleware(-100, 1000));
}
catch (Exception ex)
{
Expand Down

0 comments on commit bac6832

Please sign in to comment.