Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Delete function to BotState for parity with JavaScript #1215

Merged
merged 1 commit into from Dec 5, 2018
Merged

add Delete function to BotState for parity with JavaScript #1215

merged 1 commit into from Dec 5, 2018

Conversation

johnataylor
Copy link
Member

This brings the C# implementation in line with the JavaScript.

This is the corresponding JavaScript PR. microsoft/botbuilder-js#679

@johnataylor johnataylor merged commit d204af0 into master Dec 5, 2018
@johnataylor johnataylor deleted the johtaylo/botstate-delete branch December 5, 2018 00:11
@johnataylor
Copy link
Member Author

fixes microsoft/botframework-sdk#5175

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 44853

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 55.671%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder/BotState.cs 13 82.44%
Totals Coverage Status
Change from base Build 44824: 0.03%
Covered Lines: 5473
Relevant Lines: 9831
💛 - Coveralls

@yochay yochay mentioned this pull request Dec 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@daveta daveta Awaiting requested review from daveta

@stevengum stevengum Awaiting requested review from stevengum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnataylor @coveralls @cleemullins