Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BotTelemetryClient methods virtual #1238

Merged
merged 1 commit into from
Jan 5, 2019
Merged

Make BotTelemetryClient methods virtual #1238

merged 1 commit into from
Jan 5, 2019

Conversation

daveta
Copy link
Contributor

@daveta daveta commented Dec 13, 2018

microsoft/botframework-sdk#5194

Make BotTelemetryClient methods virtual.

I would like to be able to extend the OOTB client with additional business logic and obfuscate or augment the data being logged without having to write an IBotTelemetryClient from the scratch. For example, users will be able to opt-in/opt-out from logging and have different privacy preferences, I would like to override the TrackEvent method so I can manipulate the data based on the user that is using the bot.

@coveralls
Copy link
Collaborator

coveralls commented Dec 13, 2018 •
edited

Pull Request Test Coverage Report for Build 45391

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.792%
Totals Coverage Status
Change from base Build 45174: 0.0%
Covered Lines: 5500
Relevant Lines: 9858
💛 - Coveralls

gabog
gabog reviewed Dec 13, 2018
View reviewed changes
Copy link
Contributor

@gabog gabog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@daveta daveta merged commit 287d004 into master Jan 5, 2019
@daveta daveta deleted the daveta-va-fixes branch January 5, 2019 01:09
@daveta
Copy link
Contributor Author

daveta commented Jan 9, 2019

Associated with #1235.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabog gabog gabog left review comments

@benbrown benbrown benbrown approved these changes

@johnataylor johnataylor Awaiting requested review from johnataylor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@daveta @coveralls @benbrown @gabog