Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes, mainly for docXML that brakes the docs build. #1250

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Fixes, mainly for docXML that brakes the docs build. #1250

merged 1 commit into from
Dec 19, 2018

Conversation

JonathanFingold
Copy link
Contributor

No description provided.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 45735

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 37 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 55.792%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Connector/OAuthApiClient.cs 37 20.49%
Totals Coverage Status
Change from base Build 45174: 0.0%
Covered Lines: 5500
Relevant Lines: 9858
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 45734

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 37 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 55.792%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Connector/OAuthApiClient.cs 37 20.49%
Totals Coverage Status
Change from base Build 45174: 0.0%
Covered Lines: 5500
Relevant Lines: 9858
💛 - Coveralls

@JonathanFingold JonathanFingold requested review from daveta and removed request for cleemullins December 19, 2018 17:06
daveta
daveta approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@daveta daveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know about the "en-us" syntax. Thanks!

@daveta daveta merged commit e176ce9 into master Dec 19, 2018
@daveta daveta deleted the jofing/DocXml-1218 branch December 19, 2018 22:04
ShYuPe pushed a commit to ShYuPe/botbuilder-dotnet that referenced this pull request Aug 25, 2020
@stevengum
update CODEOWNERS (microsoft#1250)
985969d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveta daveta daveta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JonathanFingold @coveralls @daveta