Various docXML fixes: #1257
Merged
Various docXML fixes: #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JonathanFingold
commented
Dec 21, 2018
JonathanFingold
commented
- Make sure all non-test-projects build doc XML for the Documentation config.
- Fix all critical docXML issues (ones that cause problems for the documentation repo).
- Fix many non-critical docXML issues.
- TODO: review project settings for the Release config, so that the documentation pipeline continues to work properly.
- Make sure all non-test projects are building XML docs. - Address all critical docXML issues. - Fix many minor docXML issues. - TODO: review release project settings.
This reverts commit 65408eb.
This reverts commit 2c8de59.
- Make sure all non-test-projects build doc XML for the Documentation config. - Fix all critical docXML issues (ones that cause problems for the documentation repo). - Fix many non-critical docXML issues. - TODO: review project settings for the release config, so that the documentation pipeline continues to work properly.
Pull Request Test Coverage Report for Build 45996
💛 - Coveralls |
daveta
reviewed
Dec 21, 2018
...n.ApplicationInsights.Core/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.csproj
Outdated
Show resolved
Hide resolved
daveta
reviewed
Dec 21, 2018
...tion.ApplicationInsights.Core/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.xml
Show resolved
Hide resolved
daveta
reviewed
Dec 21, 2018
...plicationInsights.WebApi/Microsoft.Bot.Builder.Integration.ApplicationInsights.WebApi.csproj
Outdated
Show resolved
Hide resolved
daveta
reviewed
Dec 21, 2018
....ApplicationInsights.WebApi/Microsoft.Bot.Builder.Integration.ApplicationInsights.WebApi.xml
Outdated
Show resolved
Hide resolved
daveta
reviewed
Dec 21, 2018
...s/Microsoft.Bot.Builder.ApplicationInsights/Microsoft.Bot.Builder.ApplicationInsights.csproj
Outdated
Show resolved
Hide resolved
daveta
reviewed
Dec 21, 2018
libraries/Microsoft.Bot.Builder.Dialogs/Microsoft.Bot.Builder.Dialogs.csproj
Outdated
Show resolved
Hide resolved
daveta
reviewed
Dec 21, 2018
libraries/Microsoft.Bot.Configuration/Microsoft.Bot.Configuration.csproj
Outdated
Show resolved
Hide resolved
daveta
suggested changes
Dec 21, 2018
|
@daveta I think it should be good to go now. Replied to your email, too. |
cleemullins
approved these changes
Jan 8, 2019
daveta
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.