TranscriptLoggerMiddleware bugfix #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing a NullReferenceException bug which is thrown if the incoming Activity's From property is null in `TranscriptLoggerMiddleware`. Eg. if `BotFrameworkAdapter.CreateConversationAsync()` is triggering an 'event' Activity and for some reason does not sets the From property.
|
@mark-szabo, this looks great to me, but as it's a code change with new behavior, it needs a Unit Test that highlights the old/new behavior. Are you able to add that? |
|
@tomlm This looks great to me, but as it's your code I figured you should be the one to sign-off in case I'm missing something subtle. |
cleemullins
added
the
bug
tomlm
approved these changes
Jan 8, 2019
|
Hi @cleemullins sadly I don't have a dev env for botbuilder-dotnet, so it'd take time... If it's not fitting into your schedule, I'll do it as soon as I have time to set up a dev env and get familiar with your unit tests. |
|
Merging, per approval from @tomlm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a NullReferenceException bug which is thrown if the incoming Activity's From property is null in
TranscriptLoggerMiddleware. Eg. ifBotFrameworkAdapter.CreateConversationAsync()is triggering an 'event' Activity and for some reason does not sets the From property.