-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up typos in Activity.cs #1263
Conversation
Pull Request Test Coverage Report for Build 46089
💛 - Coveralls |
Pull Request Test Coverage Report for Build 46631
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kyle. This is great.
However... (there's always a however)
Can you remove the Activity.cs changes from this PR? That class is auto-generated from Swagger and your changes will be wiped out the next time the class is generated. The changes in the other classes ComponentDialog, DialogSet, etc, are all things we should take ASAP.
To "Fix" the Activity.cs means changing the server side code that generates the swagger file via Swashbuckle. If you are up for doing that, talk to Craig or Artur who can point you in the right direction.
Thank you, Chris. I would like to submit a new pull request for the sake of cleanliness. I do not want to risk corrupting the repository with rebases, etc. This pull request can be rejected. |
This reverts commit 0ef6e2f.
Never mind the new pull request idea. I've just added a new commit that reverts the Activity.cs commit |
I noticed some typos in the documentation comments in Activity.cs, so I fixed them. They largely appear to have been caused by copying and pasting.