Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up typos in Activity.cs #1263

Merged
merged 3 commits into from
Jan 9, 2019
Merged

Clean up typos in Activity.cs #1263

merged 3 commits into from
Jan 9, 2019

Conversation

v-kydela
Copy link
Contributor

I noticed some typos in the documentation comments in Activity.cs, so I fixed them. They largely appear to have been caused by copying and pasting.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 46089

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.792%

Totals Coverage Status
Change from base Build 45824: 0.0%
Covered Lines: 5500
Relevant Lines: 9858

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Dec 26, 2018

Pull Request Test Coverage Report for Build 46631

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 55.792%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/DialogContext.cs 16 69.72%
Totals Coverage Status
Change from base Build 45824: 0.0%
Covered Lines: 5500
Relevant Lines: 9858

💛 - Coveralls

Copy link
Contributor

@cleemullins cleemullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kyle. This is great.

However... (there's always a however)

Can you remove the Activity.cs changes from this PR? That class is auto-generated from Swagger and your changes will be wiped out the next time the class is generated. The changes in the other classes ComponentDialog, DialogSet, etc, are all things we should take ASAP.

To "Fix" the Activity.cs means changing the server side code that generates the swagger file via Swashbuckle. If you are up for doing that, talk to Craig or Artur who can point you in the right direction.

@v-kydela
Copy link
Contributor Author

v-kydela commented Jan 8, 2019

Thank you, Chris. I would like to submit a new pull request for the sake of cleanliness. I do not want to risk corrupting the repository with rebases, etc. This pull request can be rejected.

@v-kydela
Copy link
Contributor Author

v-kydela commented Jan 8, 2019

Never mind the new pull request idea. I've just added a new commit that reverts the Activity.cs commit

@cleemullins cleemullins merged commit b765300 into master Jan 9, 2019
@cleemullins cleemullins deleted the v-kydela branch January 9, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants