-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating OAuthClient API based on latest service swagger #1282
Conversation
Pull Request Test Coverage Report for Build 48449
💛 - Coveralls |
using System.Net; | ||
using System.Net.Http; | ||
|
||
public partial class OAuthClient : ServiceClient<OAuthClient>, IOAuthClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the relationship between this class, the "Old" version of this class, and the Interface.
My understanding is that this is a Breaking Change, which we can't do. I believe this needs to be OAuthClient2, and the old one can have a "[Obsolete / Depricated] attribute added to it.
@Jeffders Hey Jeff, this looks like a great improvement. There are a few breaking changes I saw in there that I don't think we'll be able to take - I called out the ones I saw, but you'll have to go through with a very careful eye. Also - do we need to port this back to SDK3? I think we only need it in V4, but as it's protocol changes I'm not clear. |
I've followed up with @Jeffders to figure out what to do with this PR. |
Updated the TokenAPI.json swagger file, and generated (for the first time), the autorest clients and supporting classes for this swagger. Then I updated the tests and BotFrameworkAdapter to use these methods.
I ran the unit tests and also did manual testing against production DirectLine:
-GetToken
-SignIn flow (with and without the magic code)
-SignOut
-GetAadTokens