Fix: Can pass QnAMakerOptions into both constructor and QnAMaker.GetAnswersAsync() w/o unintentional overwrite

[Zerryth]

Fixes #1239, #1286

Description

• Can pass QnAMakerOptions into QnAMaker constructor and QnAMaker.GetAnswersAsync() without accidentally overwriting the options passed into the constructor
• Refactored code to make changes similar to the ones in Zerryth/qna parity botbuilder-js#704 that cleans up QnAMaker readability on the js side, to keep with parity
• Replaced repeated code in constructor with ValidateOptions() (DRY)

Specific Changes

• Can pass QnAMakerOptions into QnAMaker constructor and QnAMaker.GetAnswersAsync() without accidentally overwriting the options passed into the constructor

  • Added private method HydrateOptions() to combine options passed into the constructor and GetAnswersAsync() call
  • for example if I specified in the constructor ScoreThreshold = 0.5F and in GetAnswersAsync() I provide an addition option that I want Top = 3 results, your options in the request to the QnAMaker service will specify both ScoreThreshold = 0.5F and Top = 3
  • previously the behavior is that it would overwrite constructor-passed ScoreThreshold = 0.5F to default ScoreThreshold = 0.3F and take only the GetAnswersAsync() option

• Exercised clean coding practice of abstracting lower-level detailed processes into helper functions to make code more expressive/readable. See below for functions

  • GetAnswersAsync(): HydrateOptions(), QueryQnaServiceAsync(), EmitTraceInfoAsync()
    • QueryQnaServiceAsync(): BuildRequest(), FormatQnaResultAsync()
      • BuildRequest(): SetHeaders()

[coveralls]

Pull Request Test Coverage Report for Build 48056

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 113 unchanged lines in 8 files lost coverage.
• Overall coverage increased (+13.3%) to 69.112%

---

Files with Coverage Reduction	New Missed Lines	%
/libraries/Microsoft.Bot.Builder/Integration/BotFrameworkOptions.cs	3	63.64%
/libraries/Microsoft.Bot.Builder/TranscriptLoggerMiddleware.cs	4	95.51%
/libraries/Microsoft.Bot.Builder.Dialogs/Choices/ChoiceRecognizers.cs	4	95.35%
/libraries/Microsoft.Bot.Builder.AI.QnA/QnAMaker.cs	6	96.57%
/libraries/Microsoft.Bot.Builder.Dialogs/Choices/Find.cs	7	90.57%
/libraries/Microsoft.Bot.Builder.Dialogs/Choices/ChoiceFactory.cs	18	76.03%
/libraries/Microsoft.Bot.Builder/BotFrameworkAdapter.cs	23	15.59%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs	48	0.0%

Totals
Change from base Build 46954:	13.3%
Covered Lines:	3477
Relevant Lines:	5031

---

💛 - Coveralls

[Zerryth]

• Note coverage missing on path if someone tried to query a v2.0 qna service
• Filed in separate bug: QnAMaker.ConvertLegacyResult() does not properly handle v2.0 QnA API, only v3.0 #1285

[cleemullins]

This looks great to me, but I would like a 2nd set of eyes (John? Steven?) before merging it in. I'm still a bit out-of-it from recent medical events, so a 2nd detailed review is good.

[Zerryth]

@stevengum I think you meant put the if-statement conditions into HydrateOptions() instead of ValidateOptions() :)

In any case, obliterated and removed helpers HasTopQueryOption(), HasTopQueryOption(), HasStrictFiltersQueryOption(), and HasMetadataBoostQueryOption()

And if-statement conditions are in HydrateOptions()

[Zerryth]

@stevengum post meeting ping! :)

Made changes on the edits you suggested. Please review

[stevengum]

Just waiting on @Zerryth to fix the breaking changes and not return a null value.

[Zerryth]

Awesome, thank you John & Steven.

Just ran the code I had locally without making any changes to the commit and 7 of 22 tests are failing now (why me???)

Once I get passed this shenanigans, I'll work on the param name/error throwing :)

Feedback addressed. NEeding to merge.