Updated Subscription key so tests run w/o Corpnet connection #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnataylor
approved these changes
Jan 24, 2019
Pull Request Test Coverage Report for Build 47669
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1296, #1298
The LUIS Tests are/were relying on a key file stored on an internal server. This means the tests only worked on machines connected to corpnet with access to the key server.
The tests in question don't actually need the key file, as they run against Mocks and recorded JSON files.
This PR defaults the LUIS key to "000" so if the key file isn't present, the tests will use that. I have chosen to leave the key plumbing in place, as it's needed to re-create the http playback files.