Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't warn about docs during standard debug builds #1313

Merged
merged 2 commits into from
Jan 25, 2019
Merged

Don't warn about docs during standard debug builds #1313

merged 2 commits into from
Jan 25, 2019

Conversation

cleemullins
Copy link
Contributor

Debug builds - which are the norm - don't build docs. This is done to make the builds go faster.

The PR suppresses those warnings.

@cleemullins cleemullins self-assigned this Jan 25, 2019
drub0y
drub0y approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@drub0y drub0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 :shipit:

@cleemullins cleemullins merged commit 44100b8 into master Jan 25, 2019
@cleemullins cleemullins deleted the CLM/SupressNoDocsWarningOnDebugBuilds branch January 25, 2019 20:34
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 47685

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.835%
Totals Coverage Status
Change from base Build 47683: 0.0%
Covered Lines: 5507
Relevant Lines: 9863
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drub0y drub0y drub0y approved these changes

Assignees

@cleemullins cleemullins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cleemullins @coveralls @drub0y