Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidated packages across versions. #1324

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Consolidated packages across versions. #1324

merged 1 commit into from
Jan 29, 2019

Conversation

cleemullins
Copy link
Contributor

@cleemullins cleemullins commented Jan 29, 2019 •
edited

Fixes #1310

This PR consolidates conflicting / mismatched versions of dependencies across the SDK. Specifically:

  1. Microsoft.AspNet.WebAPI has been set to 5.2.6
  2. Microsoft.Net.Test.Sdk has been set to 15.9.0
  3. Microsoft.Rest.ClientRuntime has been standardized to 2.3.13
  4. Newtonsoft.Json has been standardized to 10.0.3
  5. Moq has been standardized to 4.10.0

Also, the latest version of SourceLink has been picked up which sets the Development Dependency to true so our runtime dependency goes away.

@cleemullins cleemullins self-assigned this Jan 29, 2019
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 47857

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.97%
Totals Coverage Status
Change from base Build 47805: 0.0%
Covered Lines: 3408
Relevant Lines: 5014
💛 - Coveralls

@cleemullins cleemullins merged commit c81987b into master Jan 29, 2019
@cleemullins cleemullins deleted the CLM/UpdateSourceLink branch January 29, 2019 18:35
@cleemullins cleemullins mentioned this pull request Feb 11, 2019
Closed
@volthezz volthezz mentioned this pull request May 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@drub0y drub0y Awaiting requested review from drub0y

@johnataylor johnataylor Awaiting requested review from johnataylor

Assignees

@cleemullins cleemullins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cleemullins @coveralls @stevengum