Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for OAuthCard & Teams, and Task.Run #1329

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Conversation

Jeffders
Copy link
Member

Address these two issues:

#1236
...Use OpenUrl for'msteams' SignIn card instead of SignIn CardAction

#1273
...Properly run the task in the background

@cleemullins
Copy link
Contributor

LGTM. As soon as the build passes, I'll merge this in.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 47935

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 67.97%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder/BotFrameworkAdapter.cs 23 15.59%
Totals Coverage Status
Change from base Build 47934: 0.0%
Covered Lines: 3408
Relevant Lines: 5014

💛 - Coveralls

@cleemullins cleemullins merged commit eabb118 into master Jan 29, 2019
@cleemullins cleemullins deleted the jeffders/4_3_fixes branch January 29, 2019 19:58
@iMicknl iMicknl mentioned this pull request Mar 29, 2019
@clearab
Copy link
Contributor

clearab commented Nov 12, 2019

@cleemullins @Jeffders Why this switch away from SignIn action? That should work just fine, shouldn't it?

@EricDahlvang
Copy link
Member

@clearab this is an old pr. I think the current code in master is using ActionTypes.Signin and it is working: https://github.com/microsoft/botbuilder-dotnet/blob/master/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs#L332

new CardAction
{
    Title = _settings.Title,
    Value = link,
    Type = ActionTypes.Signin,
 },

@RohanSaini
Copy link

I am using node js. Still, the sign-in card is not working on teams. I even tried the Microsoft git repo example https://github.com/microsoft/BotBuilder-Samples/tree/master/samples/javascript_nodejs/24.bot-authentication-msgraph
How to resolve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants