change accessor to return null not throw with no factory #1330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1191
Note this is actually a change of behavior - but it is closer to the JavaScript.
Not exactly the same because JavaScript has the notion of undefined - and null is not the same. This is particularly evident if the accessor model is being used to access raw properties - as is done in the unit tests.
As the conversation in the issue suggests, its very hard to imagine this being used in this way out side of the immediate context of the dialog system where currently it must be passed in. And as other issues have covered, even in that context it is only ever used in a one particular way (as a ref and so only Get is called.)
And the change is safe for the usage in the Dialog system.