Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change accessor to return null not throw with no factory #1330

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

johnataylor
Copy link
Member

fixes #1191

Note this is actually a change of behavior - but it is closer to the JavaScript.

Not exactly the same because JavaScript has the notion of undefined - and null is not the same. This is particularly evident if the accessor model is being used to access raw properties - as is done in the unit tests.

As the conversation in the issue suggests, its very hard to imagine this being used in this way out side of the immediate context of the dialog system where currently it must be passed in. And as other issues have covered, even in that context it is only ever used in a one particular way (as a ref and so only Get is called.)

And the change is safe for the usage in the Dialog system.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 47938

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.97%

Totals Coverage Status
Change from base Build 47934: 0.0%
Covered Lines: 3408
Relevant Lines: 5014

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants