Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow choice recognizer to accept null and empty string #1333

Merged
merged 1 commit into from
Jan 29, 2019
Merged

allow choice recognizer to accept null and empty string #1333

merged 1 commit into from
Jan 29, 2019

Conversation

johnataylor
Copy link
Member

fixes #1211

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 47942

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 68.016%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/Choices/ChoiceRecognizers.cs 4 95.35%
/libraries/Microsoft.Bot.Builder.Dialogs/Choices/Find.cs 7 90.57%
Totals Coverage Status
Change from base Build 47941: 0.05%
Covered Lines: 3411
Relevant Lines: 5015
💛 - Coveralls

@v-kydela
Copy link
Contributor

I would like to review the changes and possibly amend the pull request if that's acceptable. Please stand by.

@stevengum stevengum merged commit 03636fb into master Jan 29, 2019
@stevengum stevengum deleted the johtaylo/issue1211 branch January 29, 2019 21:32
@v-kydela
Copy link
Contributor

This PR is fine. I will make a separate PR if I want to make any additional changes.

v-kydela pushed a commit that referenced this pull request Jan 31, 2019
Include test for FindChoices as an amendment to PR #1333 which fixed …
d442a3a 
…issue #1211
cleemullins added a commit that referenced this pull request Jan 31, 2019
@cleemullins
Merge pull request #1350 from Microsoft/v-kydela/FindChoicesNullTest
7dbf20b 
Include test for FindChoices as an amendment to PR #1333 which …
@hansmbakker hansmbakker mentioned this pull request May 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@cleemullins cleemullins Awaiting requested review from cleemullins

@v-kydela v-kydela Awaiting requested review from v-kydela

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Messages without text cause errors in several situations
4 participants
@johnataylor @coveralls @v-kydela @stevengum