Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token refresh: Cherry pick change from 4.2 #1336

Merged
merged 3 commits into from
Jan 30, 2019

Conversation

carlosscastro
Copy link
Member

No description provided.

…lock customers

+ Add support for custom HttpClient in client credentials
+ PR comments (tactical ones, more involved comments to be addressed in 4.3 timeframe)
+ Renaming "random noise" to "jitter"
+ Removing unnecessary interfaces
+ Adding tests
+ Upgrading ADAL to get the new constructor that accepts an http client

Soon some things to consider:

+ Move from ADAL to MSAL once it goes GA
+ Consider Polly instead of our simple retry class
+ Once ADAL manages concurrency control, remove our custom concurrency control
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 48030

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 68.016%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder/Integration/BotFrameworkOptions.cs 3 63.64%
Totals Coverage Status
Change from base Build 48002: 0.0%
Covered Lines: 3411
Relevant Lines: 5015

💛 - Coveralls

@cleemullins cleemullins merged commit cfc67a6 into master Jan 30, 2019
@cleemullins cleemullins deleted the ccastro/token-cherry-pick branch January 30, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants