Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Make Microsoft.Bot.Configuration.Tests netcoreapp #1344

Merged
merged 2 commits into from
Jan 30, 2019
Merged

[Testing] Make Microsoft.Bot.Configuration.Tests netcoreapp #1344

merged 2 commits into from
Jan 30, 2019

Conversation

JuanAr
Copy link
Collaborator

@JuanAr JuanAr commented Jan 30, 2019

  • Convert Microsoft.Bot.Configuration.Tests from Net Framework to NetcoreApp2.1 as the rest of test projects
  • Fix paths to local file resources

closes #1322

@JuanAr
Make Microsoft.Bot.Configuration.Tests netcoreapp
b2718a1 
- Convert Microsoft.Bot.Configuration.Tests from Net Framework to NetcoreApp2.1 as the rest of test projects
- Fix paths to local file resources

closes #1322
cleemullins
cleemullins approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@cleemullins cleemullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the constant, and then we'll merge this in?

tests/Microsoft.Bot.Configuration.Tests/ConfigurationLoadAndSaveTests.cs Outdated Show resolved Hide resolved
@cleemullins
Copy link
Contributor

I'll merge as soon as the build passes.

@cleemullins cleemullins merged commit eead7f1 into master Jan 30, 2019
@cleemullins cleemullins deleted the fix/testing/bot-configuration branch January 30, 2019 21:08
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 48071

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.263%
Totals Coverage Status
Change from base Build 48066: 0.0%
Covered Lines: 3495
Relevant Lines: 5046
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Project Microsoft.Bot.Configuration.Tests is NOT NetStandard / NetCore
3 participants
@JuanAr @cleemullins @coveralls