-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full implementation of ActivityHandler and MVC integration DCR #1358
Conversation
Pull Request Test Coverage Report for Build 48714
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some Minor nits, but really, this is quite nice.
libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/BotFrameworkAdapterEx.cs
Outdated
Show resolved
Hide resolved
libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/BotFrameworkAdapterEx.cs
Outdated
Show resolved
Hide resolved
libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/BotFrameworkAdapterEx.cs
Outdated
Show resolved
Hide resolved
libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/HttpHelper.cs
Show resolved
Hide resolved
libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/HttpHelper.cs
Outdated
Show resolved
Hide resolved
libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/IBotFrameworkAdapter.cs
Outdated
Show resolved
Hide resolved
libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.WebApi/BotFrameworkAdapterEx.cs
Outdated
Show resolved
Hide resolved
libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.WebApi/HttpHelper.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per comment below on the WebAPI implementation, I'm finding this "hoisting" of the BotAdapter
class up to the integration layers very strange. I don't yet see the value in this particular change at all, but, as I say in the comment, maybe I need to see what you do in the actual integration layers now to tie it all together.
libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/IBotFrameworkAdapter.cs
Outdated
Show resolved
Hide resolved
libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/IBotFrameworkAdapter.cs
Outdated
Show resolved
Hide resolved
libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.WebApi/BotFrameworkAdapterEx.cs
Outdated
Show resolved
Hide resolved
libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.WebApi/HttpHelper.cs
Outdated
Show resolved
Hide resolved
libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.WebApi/HttpHelper.cs
Outdated
Show resolved
Hide resolved
@cleemullins @sgellock @Stevenic with Ben's changes from today this should give us parity. |
TODO: