Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full implementation of ActivityHandler and MVC integration DCR #1358

Merged
merged 8 commits into from
Feb 11, 2019

Conversation

johnataylor
Copy link
Member

  • full implementation of integration for Asp Net both Core and WebApi
  • implementation of ActivityHandler and strongly typed ITurnContext
  • unit tests for ActivityHandler

TODO:

  • unit tests for integration components
  • potentially more logic in ActivityHandler, depends on what @Stevenic comes up with
  • decide on names (so far I've left the working "Ex" naming but we know we don't want to keep that)
  • update TestBots in the solution to use integration components (this can be a follow on check in)

@johnataylor johnataylor changed the title full implementation and initial unit tests DO NOT MERGE: full implementation and initial unit tests Feb 5, 2019
@coveralls
Copy link
Collaborator

coveralls commented Feb 5, 2019

Pull Request Test Coverage Report for Build 48714

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 68 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+3.6%) to 73.038%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/Choices/ChoiceFactory.cs 7 79.7%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/BotMessageHandler.cs 7 0.0%
/libraries/Microsoft.Bot.Builder/Adapters/TestAdapter.cs 54 79.86%
Totals Coverage Status
Change from base Build 48458: 3.6%
Covered Lines: 3936
Relevant Lines: 5389

💛 - Coveralls

Copy link
Contributor

@cleemullins cleemullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Minor nits, but really, this is quite nice.

Copy link
Contributor

@drub0y drub0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per comment below on the WebAPI implementation, I'm finding this "hoisting" of the BotAdapter class up to the integration layers very strange. I don't yet see the value in this particular change at all, but, as I say in the comment, maybe I need to see what you do in the actual integration layers now to tie it all together.

@cleemullins cleemullins added blocked Current progress is blocked on something else. Parity with JS Required labels Feb 7, 2019
@johnataylor johnataylor changed the title DO NOT MERGE: full implementation and initial unit tests Full implementation of ActivityHandler and MVC integration DCR Feb 8, 2019
@johnataylor
Copy link
Member Author

@cleemullins @sgellock @Stevenic with Ben's changes from today this should give us parity.

@cleemullins cleemullins merged commit f0d355f into master Feb 11, 2019
@cleemullins cleemullins deleted the johtaylo/dcr-mvc branch February 11, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants