Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply limits to the CosmosDB Key Length #1370

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Conversation

cleemullins
Copy link
Contributor

Fixes #1197

This code updates the CosmosDB key scrubbing class to enforce the 255 character length defiened by CosmosDB.

@cleemullins cleemullins added blocked Current progress is blocked on something else. Parity with JS Required labels Feb 8, 2019
@cleemullins cleemullins self-assigned this Feb 8, 2019
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 48747

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.21%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Azure/CosmosDBKeyEscape.cs 4 89.74%
Totals Coverage Status
Change from base Build 48695: 0.05%
Covered Lines: 3747
Relevant Lines: 5189

💛 - Coveralls

@benbrown
Copy link
Contributor

benbrown commented Feb 8, 2019

Here is the Javascript port of this fix: microsoft/botbuilder-js#760

Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Teams with ConversationData and PrivateConversationData ... lgtm!

@cleemullins cleemullins merged commit 83736a9 into master Feb 8, 2019
@cleemullins cleemullins removed blocked Current progress is blocked on something else. Parity with JS Required labels Feb 8, 2019
@cleemullins cleemullins deleted the CLM/CosmosDBKeyLength branch March 5, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants