additional constructor that takes raw LUIS endpoint #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleemullins
approved these changes
Feb 13, 2019
Pull Request Test Coverage Report for Build 49097
💛 - Coveralls |
stevengum
approved these changes
Feb 15, 2019
| Assert.AreEqual(service.AppId, model.ApplicationId); | ||
| Assert.AreEqual(service.SubscriptionKey, model.EndpointKey); | ||
| Assert.AreEqual(service.GetEndpoint(), model.Endpoint); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void ListApplicationFromLuisEndpoint() |
There was a problem hiding this comment.
Should this be LuisApplicationFromLuisEndpoint?
| } | ||
|
|
||
| [TestMethod] | ||
| public void ListApplicationFromLuisEndpointBadArguments() |
There was a problem hiding this comment.
Shouldn't this be LuisApplicationsFromLuisEndpointBadArguments? More precisely, shouldn't be a negative?
It's only a test name, but it shouldn't imply that invalid arguments will generate a valid LuisApplication instance.
|
@cleemullins and @stevengum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the C# implementation for microsoft/botframework-sdk#5255
The only thing to note here is that the JavaScript is slightly different because the C# has this additional LuisApplication class. Because the C# has that class I added the extra constructor on that. (Making sure to wire all the constructir overloads through the same code path.)
@stevengum is planning to do the JavaScript.