Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy support: ConnectorClient accepts custom http client and BotFrameworkAdapter passes httpClient over to clients #1382

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Proxy support: ConnectorClient accepts custom http client and BotFrameworkAdapter passes httpClient over to clients #1382

merged 1 commit into from
Feb 15, 2019

Conversation

carlosscastro
Copy link
Member

@carlosscastro carlosscastro commented Feb 14, 2019 •
edited

Fixes #1360

@carlosscastro
Proxy support: ConnectorClient accepts custom http client and BotFram…
fe4f552 
…eworkAdapter passes httpClient over to clients
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 49198

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.454%
Totals Coverage Status
Change from base Build 49187: 0.0%
Covered Lines: 3958
Relevant Lines: 5316
💛 - Coveralls

@cleemullins cleemullins merged commit 27b7a20 into master Feb 15, 2019
@cleemullins cleemullins deleted the ccastro/custom-http-client-connector branch February 15, 2019 02:18
@clintwar clintwar mentioned this pull request Aug 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carlosscastro @coveralls @cleemullins