Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stylecop] Fix warnings in the AppInsight.WebApi.Tests project #1490

Merged
merged 3 commits into from
Mar 25, 2019
Merged

[Stylecop] Fix warnings in the AppInsight.WebApi.Tests project #1490

merged 3 commits into from
Mar 25, 2019

Conversation

ceciliaavila
Copy link
Collaborator

@ceciliaavila ceciliaavila commented Mar 18, 2019 •
edited by gasper-az

  • Fix spacing
  • Add trailing comma
  • Fix documentation
  • Reorder usings

@ceciliaavila ceciliaavila mentioned this pull request Mar 18, 2019
Closed
@gasper-az gasper-az force-pushed the fix/stylecop/AppInsights.WebApi.Tests branch from 571b161 to dd21175 Compare March 19, 2019 19:27
@gasper-az gasper-az marked this pull request as ready for review March 19, 2019 19:28
@coveralls
Copy link
Collaborator

coveralls commented Mar 19, 2019 •
edited

Pull Request Test Coverage Report for Build 51993

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 84 unchanged lines in 3 files lost coverage.
  • Overall coverage remained the same at 75.588%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/WaterfallStepContext.cs 8 65.22%
/libraries/Microsoft.Bot.Builder.Dialogs/DialogContext.cs 27 72.73%
/libraries/Microsoft.Bot.Builder/Adapters/TestAdapter.cs 49 81.29%
Totals Coverage Status
Change from base Build 51599: 0.0%
Covered Lines: 4304
Relevant Lines: 5694
💛 - Coveralls

@axelsrz axelsrz merged commit 6bff3b6 into master Mar 25, 2019
@cleemullins cleemullins deleted the fix/stylecop/AppInsights.WebApi.Tests branch September 12, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gasper-az gasper-az gasper-az left review comments

@axelsrz axelsrz axelsrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ceciliaavila @coveralls @axelsrz @gasper-az @Maihav