Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StyleCop] Fix all the warnings on TemplateManager #1498

Merged
merged 2 commits into from
Mar 26, 2019
Merged

[StyleCop] Fix all the warnings on TemplateManager #1498

merged 2 commits into from
Mar 26, 2019

Conversation

ceciliaavila
Copy link
Collaborator

  • Add documentation for methods
  • Move classes to new file
  • Fix spacing

@ceciliaavila ceciliaavila mentioned this pull request Mar 18, 2019
Closed
@Aliandi @Bill7zz
[StyleCop] Fix all the warnings on TemplateManager
3d3e17a 
- Add documentation for methods
- Move classes to new file
- Fix spacing
@ParadoxARG ParadoxARG force-pushed the fix/stylecop/Bot.Builder.TemplateManager branch from 0be7075 to 3d3e17a Compare March 20, 2019 15:01
@coveralls
Copy link
Collaborator

coveralls commented Mar 20, 2019 •
edited

Pull Request Test Coverage Report for Build 52137

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 104 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.04%) to 75.552%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.TemplateManager/DictionaryRenderer.cs 3 82.35%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/BotFrameworkHttpAdapter.cs 7 58.33%
/libraries/Microsoft.Bot.Builder.Dialogs/WaterfallStepContext.cs 8 65.22%
/libraries/Microsoft.Bot.Builder.TemplateManager/TemplateManager.cs 10 79.25%
/libraries/Microsoft.Bot.Builder.Dialogs/DialogContext.cs 27 72.73%
/libraries/Microsoft.Bot.Builder/Adapters/TestAdapter.cs 49 81.29%
Totals Coverage Status
Change from base Build 51712: -0.04%
Covered Lines: 4308
Relevant Lines: 5702
💛 - Coveralls

@ParadoxARG ParadoxARG marked this pull request as ready for review March 20, 2019 15:35
@cleemullins
Copy link
Contributor

@ceciliaavila please check the license/cla so that we can get this merged. That's the only thing holding up this PR.

@gasper-az
Copy link
Contributor

@ceciliaavila please check the license/cla so that we can get this merged. That's the only thing holding up this PR.

@cleemullins, the CLA and the others checks have successfully passed.

@cleemullins cleemullins merged commit 246c8ea into master Mar 26, 2019
@cleemullins cleemullins deleted the fix/stylecop/Bot.Builder.TemplateManager branch March 26, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ceciliaavila @coveralls @cleemullins @gasper-az @Aliandi